Skip to content

bpo-37433: Add additional test for multi-line SyntaxError #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2019
Merged

bpo-37433: Add additional test for multi-line SyntaxError #15003

merged 1 commit into from
Jul 29, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jul 29, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 29, 2019
@asottile asottile changed the title bpo-37433;Add additional test for multi-line SyntaxError bpo-37433: Add additional test for multi-line SyntaxError Jul 29, 2019
@asottile
Copy link
Contributor Author

Before the previous patch it failed with:

======================================================================
FAIL: test_syntaxerror_invalid_escape_sequence_multi_line (__main__.CmdLineTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/asottile/workspace/cpython/Lib/test/test_cmd_line_script.py", line 637, in test_syntaxerror_invalid_escape_sequence_multi_line
    self.assertEqual(
AssertionError: Lists differ: [b'    ', b'                                    [49061 chars]\\q'] != [b'    foo = """\\q', b'          ^', b'SyntaxEr[29 chars]\\q']

First differing element 0:
b'    '
b'    foo = """\\q'

Diff is 53681 characters long. Set self.maxDiff to None to see it.

======================================================================

@pablogsal pablogsal self-assigned this Jul 29, 2019
@pablogsal pablogsal self-requested a review July 29, 2019 15:05
@pablogsal
Copy link
Member

LGTM

Thanks again @asottile 🎉

@pablogsal pablogsal merged commit 44212ec into python:master Jul 29, 2019
@miss-islington
Copy link
Contributor

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15005 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2019
@asottile @miss-islington
Add additional test for multi-line SyntaxError (pythonGH-15003)
0768f40 
(cherry picked from commit 44212ec)

Co-authored-by: Anthony Sottile <[email protected]>
miss-islington added a commit that referenced this pull request Jul 29, 2019
@miss-islington @asottile
Add additional test for multi-line SyntaxError (GH-15003)
bf0b8a6 
(cherry picked from commit 44212ec)

Co-authored-by: Anthony Sottile <[email protected]>
@asottile asottile deleted the more_syntaxerror_tests_bpo_37433 branch July 29, 2019 16:06
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@asottile @lisroach
Add additional test for multi-line SyntaxError (pythonGH-15003)
724b0d7
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asottile @DinoV
Add additional test for multi-line SyntaxError (pythonGH-15003)
878ed3a
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@asottile @websurfer5
Add additional test for multi-line SyntaxError (pythonGH-15003)
3ae1d68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asottile @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni