Skip to content

[3.7] bpo-37730: Fix usage of NotImplemented instead of NotImplementedError in docs. (GH-15062). #15106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2019
Merged

[3.7] bpo-37730: Fix usage of NotImplemented instead of NotImplementedError in docs. (GH-15062). #15106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Doc/library/winreg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ This module offers the following functions:
*key* is an already open key, or one of the predefined :ref:`HKEY_* constants
<hkey-constants>`.

Will generally raise :exc:`NotImplemented` if executed on a 32-bit operating
Will generally raise :exc:`NotImplementedError` if executed on a 32-bit operating
system.

If the key is not on the reflection list, the function succeeds but has no
Expand All @@ -471,7 +471,7 @@ This module offers the following functions:
*key* is an already open key, or one of the predefined :ref:`HKEY_* constants
<hkey-constants>`.

Will generally raise :exc:`NotImplemented` if executed on a 32-bit operating
Will generally raise :exc:`NotImplementedError` if executed on a 32-bit operating
system.

Restoring reflection for a key does not affect reflection of any subkeys.
Expand All @@ -486,7 +486,7 @@ This module offers the following functions:

Returns ``True`` if reflection is disabled.

Will generally raise :exc:`NotImplemented` if executed on a 32-bit
Will generally raise :exc:`NotImplementedError` if executed on a 32-bit
operating system.


Expand Down
8 changes: 4 additions & 4 deletions PC/clinic/winreg.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions PC/winreg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,7 @@ winreg.DisableReflectionKey

Disables registry reflection for 32bit processes running on a 64bit OS.

Will generally raise NotImplemented if executed on a 32bit OS.
Will generally raise NotImplementedError if executed on a 32bit OS.

If the key is not on the reflection list, the function succeeds but has
no effect. Disabling reflection for a key does not affect reflection
Expand All @@ -1706,7 +1706,7 @@ of any subkeys.

static PyObject *
winreg_DisableReflectionKey_impl(PyObject *module, HKEY key)
/*[clinic end generated code: output=830cce504cc764b4 input=a6c9e5ca5410193c]*/
/*[clinic end generated code: output=830cce504cc764b4 input=70bece2dee02e073]*/
{
HMODULE hMod;
typedef LONG (WINAPI *RDRKFunc)(HKEY);
Expand Down Expand Up @@ -1742,14 +1742,14 @@ winreg.EnableReflectionKey

Restores registry reflection for the specified disabled key.

Will generally raise NotImplemented if executed on a 32bit OS.
Will generally raise NotImplementedError if executed on a 32bit OS.
Restoring reflection for a key does not affect reflection of any
subkeys.
[clinic start generated code]*/

static PyObject *
winreg_EnableReflectionKey_impl(PyObject *module, HKEY key)
/*[clinic end generated code: output=86fa1385fdd9ce57 input=7748abbacd1e166a]*/
/*[clinic end generated code: output=86fa1385fdd9ce57 input=eeae770c6eb9f559]*/
{
HMODULE hMod;
typedef LONG (WINAPI *RERKFunc)(HKEY);
Expand Down Expand Up @@ -1785,12 +1785,12 @@ winreg.QueryReflectionKey

Returns the reflection state for the specified key as a bool.

Will generally raise NotImplemented if executed on a 32bit OS.
Will generally raise NotImplementedError if executed on a 32bit OS.
[clinic start generated code]*/

static PyObject *
winreg_QueryReflectionKey_impl(PyObject *module, HKEY key)
/*[clinic end generated code: output=4e774af288c3ebb9 input=9f325eacb5a65d88]*/
/*[clinic end generated code: output=4e774af288c3ebb9 input=a98fa51d55ade186]*/
{
HMODULE hMod;
typedef LONG (WINAPI *RQRKFunc)(HKEY, BOOL *);
Expand Down