bpo-30273: update distutils.sysconfig #1515
Conversation
compiled out-of-tree (builddir != srcdir). (see also bpo-15366)
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
Updated GitHub username on b.p.o user details (already signed the CLA)
|
| return base | ||
| if _sys_home: | ||
| incdir = os.path.join(_sys_home, 'Include') | ||
| return _sys_home or project_base |
There was a problem hiding this comment.
Calling normpath() on these paths shouldn't hurt.
There was a problem hiding this comment.
Sure, but just doing what was already there (and note that they are used "bare" everywhere else in the file).
There was a problem hiding this comment.
Sorry, I was confused by the "unified diff" view. With the "Split" view, it's better :-) Ok, your change doesn't remove any normpath() call.
I removed the CLA status: the CLA status was then updated properly ;-) |
|
On the coverage job, 2 tests failed (test_traceback test_xml_etree) but it doesn't seem to be related to this change? |
|
Ok, I succeeded to reproduce the bug and validate that your change fixed it. Thanks! Would you mind to backport the change to 3.6, 3.5 and 2.7 branches please? https://docs.python.org/devguide/committing.html#backporting-changes-to-an-older-version |
|
I removed needs backport to 3.5 and 3.6 labels because they were done. |
|
@Mariatta: " Is backport still needed for 2.7?" I removed this label: https://bugs.python.org/issue30273#msg317067 |
Fixes include directory returned when Python is compiled out-of-tree (builddir != srcdir) and run from a venv. (see also bpo-15366)