-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-37868: Improve is_dataclass for instances. #15325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-37868: Improve is_dataclass for instances. #15325
Conversation
Lib/test/test_dataclasses.py
Outdated
|
||
# class A above is really testing the same things as: | ||
class B: | ||
__dataclass_fields = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__dataclass_fields = [] | |
__dataclass_fields__ = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, Serhiy.
…he same thing is being tested.
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
(cherry picked from commit b0f4dab) Co-authored-by: Eric V. Smith <[email protected]>
GH-15339 is a backport of this pull request to the 3.8 branch. |
GH-15340 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit b0f4dab) Co-authored-by: Eric V. Smith <[email protected]>
(cherry picked from commit b0f4dab) Co-authored-by: Eric V. Smith <[email protected]>
(cherry picked from commit b0f4dab) Co-authored-by: Eric V. Smith <[email protected]>
|
https://bugs.python.org/issue37868