Skip to content

Less harsh implementation for issubclass() #15394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Less harsh implementation for issubclass() #15394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/_py_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from _weakrefset import WeakSet

from warnings import warn

def get_cache_token():
"""Returns the current ABC cache token.
Expand Down Expand Up @@ -108,7 +108,8 @@ def __instancecheck__(cls, instance):
def __subclasscheck__(cls, subclass):
"""Override for issubclass(subclass, cls)."""
if not isinstance(subclass, type):
raise TypeError('issubclass() arg 1 must be a class')
warn('issubclass() arg 1 is not a class. Returning False.')
return False
# Check cache
if subclass in cls._abc_cache:
return True
Expand Down