-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Typo in math.prod example #15614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in math.prod example #15614
Conversation
Change in whatsnew document for 3.8.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for catching this. cc: @rhettinger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGM
Hi @ashwinvis Thanks for the contribution. Please don't forget the CLA :-) |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ashwinvis.
The changes look good to me. Since this is a typo correction, we can skip the bpo issue and news entry (particularly since it's correcting "what's new"). Also, this should be backported 3.8.
Thanks @ashwinvis for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
(cherry picked from commit 1a8de82) Co-authored-by: Ashwin Vishnu <[email protected]>
GH-15772 is a backport of this pull request to the 3.8 branch. |
Thanks @ashwinvis for your contribution! |
(cherry picked from commit 1a8de82) Co-authored-by: Ashwin Vishnu <[email protected]>
Trivial change in whatsnew document for 3.8.