Skip to content

bpo-29898: Fix incorrect env variable name #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2017

Conversation

berkerpeksag
Copy link
Member

It should read PYTHONLEGACYWINDOWSSTDIO as stated
in section "Add legacy mode" in PEP 528.

It should read PYTHONLEGACYWINDOWSSTDIO as stated
in section "Add legacy mode" in PEP 528.
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also, didn't find any other instances of this name after grepping through the source.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this!

@berkerpeksag berkerpeksag merged commit 87fa8a7 into python:master May 16, 2017
@berkerpeksag berkerpeksag deleted the 29898-fix-env-var-name branch May 16, 2017 09:36
@berkerpeksag
Copy link
Member Author

Thanks for the reviews!

berkerpeksag added a commit to berkerpeksag/cpython that referenced this pull request May 16, 2017
It should read PYTHONLEGACYWINDOWSSTDIO as stated
in section "Add legacy mode" in PEP 528.(cherry picked from commit 87fa8a7)
berkerpeksag added a commit that referenced this pull request May 16, 2017
It should read PYTHONLEGACYWINDOWSSTDIO as stated
in section "Add legacy mode" in PEP 528.

(cherry picked from commit 87fa8a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants