[3.8] bpo-37953: Fix ForwardRef hash and equality checks (GH-15400) #16128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again. https://bugs.python.org/issue37953 (cherry picked from commit e082e7c) Co-authored-by: plokmijnuhby <[email protected]>
miss-islington
requested review from
gvanrossum and
ilevkivskyi
as code owners
bedevere-bot
added
type-bug
ilevkivskyi
approved these changes
Sep 13, 2019
|
@plokmijnuhby and @ilevkivskyi: Status check is done, and it's a success ✅ . |
|
@plokmijnuhby and @ilevkivskyi: Status check is done, and it's a success ✅ . |
1 similar comment
|
@plokmijnuhby and @ilevkivskyi: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally if we stick a ForwardRef in a dictionary we would like to reliably be able to get it out again.
https://bugs.python.org/issue37953
(cherry picked from commit e082e7c)
Co-authored-by: plokmijnuhby [email protected]
https://bugs.python.org/issue37953