Skip to content

[3.8] bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. (GH-15652) #16129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 13, 2019

  • Fix a crash in comparing with float (and maybe other crashes).
  • They are now never equal to strings and non-integer numbers.
  • Comparison with a large number no longer raises OverflowError.
  • Arbitrary exceptions no longer silenced in constructors and comparisons.
  • TypeError raised in the constructor contains now the name of the type.
  • Accept only ChannelID and int-like objects in channel functions.
  • Accept only InterpreterId, int-like objects and str in the InterpreterId constructor.
  • Accept int-like objects, not just int in interpreter related functions.
    (cherry picked from commit bf16991)

Co-authored-by: Serhiy Storchaka [email protected]

https://bugs.python.org/issue38005

…D. (pythonGH-15652)

* Fix a crash in comparing with float (and maybe other crashes).
* They are now never equal to strings and non-integer numbers.
* Comparison with a large number no longer raises OverflowError.
* Arbitrary exceptions no longer silenced in constructors and comparisons.
* TypeError raised in the constructor contains now the name of the type.
* Accept only ChannelID and int-like objects in channel functions.
* Accept only InterpreterId, int-like objects and str in the InterpreterId constructor.
* Accept int-like objects, not just int in interpreter related functions.
(cherry picked from commit bf16991)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@serhiy-storchaka: Status check is done, and it's a failure ❌ .

@miss-islington miss-islington deleted the backport-bf16991-3.8 branch September 14, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants