Skip to content

[3.8] bpo-38234: read_pth_file() now returns PyStatus (GH-16338) #16340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 23, 2019

Refactor path configuration code:

  • read_pth_file() now returns PyStatus to report errors, rather than
    calling Py_FatalError().
  • Move argv0_path and zip_path buffers out of PyCalculatePath
    structures.
  • On Windows, _PyPathConfig.home is now preferred over PyConfig.home.
    (cherry picked from commit 85ce0a7)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue38234

Refactor path configuration code:

* read_pth_file() now returns PyStatus to report errors, rather than
  calling Py_FatalError().
* Move argv0_path and zip_path buffers out of PyCalculatePath
  structures.
* On Windows, _PyPathConfig.home is now preferred over PyConfig.home.
(cherry picked from commit 85ce0a7)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7f7cd89 into python:3.8 Sep 23, 2019
@miss-islington miss-islington deleted the backport-85ce0a7-3.8 branch September 23, 2019 23:16
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants