closes bpo-38174: Update vendored expat library to 2.2.8. #16346
Conversation
There was a problem hiding this comment.
Using my https://github.com/vstinner/misc/blob/master/cpython/cpython_rebuild_expat_dir.sh script (modify TAG= at the first line to put: TAG=R_2_2_8), I get a very similar result, except that my script also removed Modules/expat/loadlibrary.c. loadlibrary.c has been removed from libexpat: libexpat/libexpat@5d34a70
"replace loadlibrary.c and RtlGenRandom call with rand_s() on windows"
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again.
…On Tue, Sep 24, 2019, at 03:18, Victor Stinner wrote:
***@***.**** requested changes on this pull request.
Using my
https://github.com/vstinner/misc/blob/master/cpython/cpython_rebuild_expat_dir.sh script (modify TAG= at the first line to put: TAG=R_2_2_8), I get a very similar result, except that my script also removed Modules/expat/loadlibrary.c. loadlibrary.c has been removed from libexpat: ***@***.*** <libexpat/libexpat@5d34a70>
"replace loadlibrary.c and RtlGenRandom call with rand_s() on windows"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16346?email_source=notifications&email_token=AABVSTSGWWLMHIEESA2U6JDQLHSNTA5CNFSM4IZ2KYIKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFWGI4I#pullrequestreview-292316273>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABVSTVTJVMOFVGL6FHT7ELQLHSNTANCNFSM4IZ2KYIA>.
|
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7, 3.8. |
|
I'm having trouble backporting to |
|
Sorry, @benjaminp, I could not cleanly backport this to |
|
Sorry @benjaminp, I had trouble checking out the |
|
Sorry, @benjaminp, I could not cleanly backport this to |
…6346) Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.. (cherry picked from commit 52b9408) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-16407 is a backport of this pull request to the 3.7 branch. |
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @benjaminp, I had trouble checking out the |
…6346) Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.. (cherry picked from commit 52b9408) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-16408 is a backport of this pull request to the 2.7 branch. |
…6346) Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes. (cherry picked from commit 52b9408) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-16409 is a backport of this pull request to the 3.8 branch. |
…6346) Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.. (cherry picked from commit 52b9408) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-16410 is a backport of this pull request to the 3.6 branch. |
Fixes CVE-2019-15903. See full changelog at https://github.com/libexpat/libexpat/blob/R_2_2_8/expat/Changes.
https://bugs.python.org/issue38174