[3.7] bpo-36871: Ensure method signature is used when asserting mock calls to a method (GH13261) #16372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a method (GH13261) * Fix call_matcher for mock when using methods * Add NEWS entry * Use None check and convert doctest to unittest * Use better name for mock in tests. Handle _SpecState when the attribute was not accessed and add tests. * Use reset_mock instead of reinitialization. Change inner class constructor signature for check * Reword comment regarding call object lookup logic (cherry picked from commit c961278) Co-authored-by: Xtreak <[email protected]>
|
already applied in #15577 |
|
@tirkarthi and @cjw296: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@tirkarthi and @cjw296: Status check is done, and it's a failure ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix call_matcher for mock when using methods
Add NEWS entry
Use None check and convert doctest to unittest
Use better name for mock in tests. Handle _SpecState when the attribute was not accessed and add tests.
Use reset_mock instead of reinitialization. Change inner class constructor signature for check
Reword comment regarding call object lookup logic
(cherry picked from commit c961278)
Co-authored-by: Xtreak [email protected]
https://bugs.python.org/issue36871