Skip to content

Doc: Several fixes and improvements for 3.9 whatsnew #16375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

aeros
Copy link
Contributor

@aeros aeros commented Sep 25, 2019

The motivation behind this PR was seeing multiple broken links within https://docs.python.org/3.9/whatsnew/3.9.html (including in my own recent addition). It can be a bit tricky to get the Sphinx roles exactly right. While fixing the broken Sphinx roles, I also added a few new ones and made a few minor grammar fixes.

To verify that the Sphinx roles were fixed and that the new ones were correct, I compared https://docs.python.org/3.9/whatsnew/3.9.html to a local copy created from make html within the PR branch.

@aeros aeros requested a review from 1st1 September 25, 2019 17:20
@1st1 1st1 requested a review from rhettinger September 25, 2019 17:36
@1st1
Copy link
Member

1st1 commented Sep 25, 2019

Looks good, copying @rhettinger as he's the editor.

@1st1 1st1 removed their request for review September 25, 2019 17:36
@aeros
Copy link
Contributor Author

aeros commented Sep 25, 2019

Thanks @rhettinger.

Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@matrixise matrixise changed the title Several fixes and improvements for 3.9 whatsnew Doc: Several fixes and improvements for 3.9 whatsnew Sep 26, 2019
@matrixise matrixise merged commit 6a10d59 into python:master Sep 26, 2019
@aeros aeros deleted the whatsnew-3.9-sphinx branch September 26, 2019 23:59
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants