bpo-29102: Add a unique ID to PyInterpreterState. #1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericsnowcurrently, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @birkenfeld and @ncoghlan to be potential reviewers. |
vstinner
reviewed
May 17, 2017
| @@ -821,6 +821,14 @@ been created. | |||
| :c:func:`PyThreadState_Clear`. | |||
|
|
|||
|
|
|||
| .. c:function:: PY_INT64_T PyInterpreterState_GetID(PyInterpreterState *interp) | |||
There was a problem hiding this comment.
Python 3.6 now uses stdint.h: please use directly uint64_t.
There was a problem hiding this comment.
Why unsigned? Did you mean int64_t?
There was a problem hiding this comment.
Oh right, int64_t. By the way, extract of master:
#define PY_INT64_T int64_t
ericsnowcurrently
force-pushed
the
interpreter-id
branch
5 times, most recently
from
4bcf3f2 to
da8439a
Compare
ericsnowcurrently
force-pushed
the
interpreter-id
branch
from
da8439a to
4797749
Compare
zooba
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see http://bugs.python.org/issue29102)