Skip to content

bpo-36670: fixed encoding issue with libregrtest on win systems #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-36670: fixed encoding issue with libregrtest on win systems #16456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/libregrtest/win_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def start(self):
self.p = subprocess.Popen(command, stdout=command_stdout, cwd=support.SAVEDCWD)

# Close our copy of the write end of the pipe
os.close(command_stdout)
# os.close(command_stdout)

def close(self):
if self.p is None:
Expand All @@ -79,7 +79,7 @@ def read_output(self):
if res != 0:
return

return overlapped.getbuffer().decode()
return overlapped.getbuffer().decode(encoding='oem', errors='ignore')

def getloadavg(self):
typeperf_output = self.read_output()
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2019-09-28-09-59-16.bpo-36670.g9nzfJ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fixed encoding issues with test execution on non english systems these
systems will return default load 0.0