Skip to content

bpo-38321: Fix _testcapimodule.c warning #16494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/_testcapimodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,7 @@ unicode_asutf8andsize(PyObject *self, PyObject *args)
return NULL;
}

buffer = PyUnicode_AsUTF8AndSize(unicode, &utf8_len);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my editor removes trailing spaces. Trailing spaces must die!

buffer = PyUnicode_AsUTF8AndSize(unicode, &utf8_len);
if (buffer == NULL) {
return NULL;
}
Expand Down Expand Up @@ -6406,7 +6406,7 @@ static PyType_Spec HeapCTypeWithDict_spec = {

static struct PyMemberDef heapctypewithnegativedict_members[] = {
{"dictobj", T_OBJECT, offsetof(HeapCTypeWithDictObject, dict)},
{"__dictoffset__", T_PYSSIZET, -sizeof(void*), READONLY},
{"__dictoffset__", T_PYSSIZET, -(Py_ssize_t)sizeof(void*), READONLY},
{NULL} /* Sentinel */
};

Expand Down