bpo-38341: Add SMTPNotSupportedError in the exports of smtplib

[rockwelln]

Pretty simple add in the all variable, the missing exception SMTPNotSupportedError

https://bugs.python.org/issue38341

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@rockwelln

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

[brandtbucher]

Thanks for your time @rockwelln, and welcome to CPython! 😎

[brandtbucher]

This looks like a good change. Can you also create a NEWS entry, since this changes smtplib's exported names?

Just something simple, like:

Added :exc:`smtplib.SMTPNotSupportedError` to ``__all__`` in :mod:`smtplib`.

[rockwelln]

Thank you @brandtbucher :-), I posted the news.
Don't hesitate if I missed something, it's the first time I propose a change in CPython.

[brandtbucher]

Awesome. I assume you’ve seen the bot’s message about the CLA?

[rockwelln]

thanks!
about the CLA, I signed it few minutes ago, it should be ok now.

[maxking]

Thanks for working on this @rockwelln

Since this is a public API (https://docs.python.org/3/library/smtplib.html?highlight=smtplib#smtplib.SMTPNotSupportedError) it should be exported.

[bedevere-bot]

@maxking: Please replace # with GH- in the commit message next time. Thanks!

[miss-islington]

Thanks @rockwelln for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

[miss-islington]

Sorry @rockwelln and @maxking, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3faf826e5879536d2272f1a51c58965a16827f81 3.8

[bedevere-bot]

GH-16590 is a backport of this pull request to the 3.7 branch.

[brandtbucher]

Congrats on your first CPython contribution @rockwelln! 🍾

Looking forward to seeing more from you in the future.

[rockwelln]

thank you very much @brandtbucher for your support. this first experience was a pleasure.
I'd be happy to contribute again.

[miss-islington]

Thanks @rockwelln for the PR, and @maxking for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

[bedevere-bot]

GH-16721 is a backport of this pull request to the 3.8 branch.

[ned-deily]

(The 3.8 autobackport failed for some reason originally, manually restarted it.)