Skip to content

[3.8] bpo-36670: regrtest bug fixes (GH-16537) #16538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 2, 2019

  • Fix TestWorkerProcess.repr(): start_time is only valid
    if _popen is not None.
  • Fix _kill(): don't set _killed to True if _popen is None.
  • _run_process(): only set _killed to False after calling
    run_test_in_subprocess().
    (cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue36670

* Fix TestWorkerProcess.__repr__(): start_time is only valid
  if _popen is not None.
* Fix _kill(): don't set _killed to True if _popen is None.
* _run_process(): only set _killed to False after calling
  run_test_in_subprocess().
(cherry picked from commit 2ea71a0)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit a72de93 into python:3.8 Oct 2, 2019
@miss-islington miss-islington deleted the backport-2ea71a0-3.8 branch October 2, 2019 11:54
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants