Skip to content

bpo-26128: Added __init__to STARTUPINFO #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2017
Merged

bpo-26128: Added __init__to STARTUPINFO #171

merged 1 commit into from
Feb 25, 2017

Conversation

codenamesubho
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Feb 19, 2017
@codenamesubho codenamesubho force-pushed the bpo-26128 branch 2 times, most recently from 21458f3 to f3f03b5 Compare February 19, 2017 11:01
@sayanchowdhury sayanchowdhury mentioned this pull request Feb 19, 2017
Closed
sayanchowdhury
sayanchowdhury suggested changes Feb 19, 2017
View reviewed changes
Lib/subprocess.py Outdated
hStdOutput = None
hStdError = None
wShowWindow = 0
def __init__(self,dwFlags=0,hStdInput=None,hStdOutput=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be implemented via keyword only arguments as the Terry suggested in the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. and spaces after the args

@ncoghlan ncoghlan mentioned this pull request Feb 22, 2017
Closed
@ncoghlan ncoghlan self-assigned this Feb 23, 2017
@ncoghlan
Copy link
Contributor

OK, I've figured out how to push updates back to PR branches (hence the rebase atop the master branch), so next step will be to add the bookkeeping updates (ACKS, NEWS, What's New) and then merge the change.

@codenamesubho
Copy link
Contributor Author

codenamesubho commented Feb 24, 2017 •
edited
Loading

so next step will be to add the bookkeeping updates (ACKS, NEWS, What's New) and then merge the change.

@ncoghlan , Anymore changes I need to do for this patch?

@codenamesubho codenamesubho force-pushed the bpo-26128 branch 2 times, most recently from 0ceb455 to c668fb4 Compare February 25, 2017 13:16
@codenamesubho
bpo-26128: Added __init__to STARTUPINFO
03d755f 
- Added tests for the code
- Added docs
@codenamesubho
Copy link
Contributor Author

@ncoghlan Added Acks and News, wasn't sure what to write in "What's New". Letme know if anything is missing. Thanks.

@ncoghlan ncoghlan merged commit ae160bb into python:master Feb 25, 2017
@ncoghlan
Copy link
Contributor

For library changes, the What's New guide is generally just a feature-focused summary of the changes added in Misc/NEWS. However, given how conflict-prone Misc/NEWS is at the moment, I went ahead and merged this without the What's New changes (there's generally a review pass through Misc/NEWS around the beta phase to look for feature additions that aren't mentioned in What's New yet).

@ncoghlan
Copy link
Contributor

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 3.9.3 to 3.10.0 (#171)
4113852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayanchowdhury sayanchowdhury sayanchowdhury requested changes

Assignees

@ncoghlan ncoghlan

Labels
sprint type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codenamesubho @the-knights-who-say-ni @ncoghlan @sayanchowdhury @serhiy-storchaka @Mariatta