Skip to content

bpo-9495: argparse unittest tracebacks are confusing if an error is raised when not expected #17120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

bpo-9495: argparse unittest tracebacks are confusing if an error is raised when not expected #17120

merged 1 commit into from
Feb 21, 2020

Conversation

alclarks
Copy link
Contributor

@alclarks alclarks commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Hi,

This is my first contribution to CPython - fixing the issue at https://bugs.python.org/issue9495

@brandtbucher

https://bugs.python.org/issue9495

@brandtbucher
Copy link
Member

Thanks for the PR @alclarks!

brandtbucher
brandtbucher approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me!

@brandtbucher
Copy link
Member

@rhettinger

@alclarks
Copy link
Contributor Author

Hi @rhettinger, if this change looks good can it please be merged?

aeros
aeros approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alclarks! Sorry for the wait, LGTM.

taleinat
taleinat approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@taleinat taleinat merged commit d4331c5 into python:master Feb 21, 2020
@taleinat
Copy link
Contributor

Congrats on your first contribution to Python, @alclarks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@aeros aeros aeros approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alclarks @brandtbucher @taleinat @aeros @the-knights-who-say-ni @bedevere-bot