bpo-15243: Specify __prepare__ should be a classmethod #17124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your time @alclarks, and welcome to CPython! 😎 |
brandtbucher
approved these changes
Nov 12, 2019
|
Hi @berkerpeksag, if this change looks good can it please be merged? |
berkerpeksag
approved these changes
Jan 25, 2020
There was a problem hiding this comment.
LGTM, thanks! The example I mentioned in the issue seems to be removed without a replacement in c2ccac7.
|
Thanks @alclarks for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-18185 is a backport of this pull request to the 3.8 branch. |
|
GH-18186 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2020
(cherry picked from commit 7de6174) Co-authored-by: alclarks <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2020
(cherry picked from commit 7de6174) Co-authored-by: alclarks <[email protected]>
berkerpeksag
pushed a commit
that referenced
this pull request
Jan 25, 2020
(cherry picked from commit 7de6174) Co-authored-by: alclarks <[email protected]>
berkerpeksag
pushed a commit
that referenced
this pull request
Jan 25, 2020
(cherry picked from commit 7de6174) Co-authored-by: alclarks <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is an updated patch for the issue https://bugs.python.org/issue15243 - specifying that prepare should be a classmethod.
@brandtbucher
https://bugs.python.org/issue15243