Skip to content

bpo-38821: Fix crash in argparse when using gettext #17192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 20, 2019
Merged

bpo-38821: Fix crash in argparse when using gettext #17192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72eac26
bpo-38821: Fix crash in argparse when using gettext
federicobond Nov 16, 2019
7c58f52
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 16, 2019
0a848c6
Update Misc/NEWS.d/next/Library/2019-11-16-23-26-25.bpo-38821.-albNN.rst
federicobond Nov 19, 2019
877600b
Update Misc/NEWS.d/next/Library/2019-11-16-23-26-25.bpo-38821.-albNN.rst
federicobond Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/argparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2148,10 +2148,11 @@ def _match_argument(self, action, arg_strings_pattern):
OPTIONAL: _('expected at most one argument'),
ONE_OR_MORE: _('expected at least one argument'),
}
default = ngettext('expected %s argument',
msg = nargs_errors.get(action.nargs)
if msg is None:
msg = ngettext('expected %s argument',
'expected %s arguments',
action.nargs) % action.nargs
msg = nargs_errors.get(action.nargs, default)
raise ArgumentError(action, msg)

# return the number of arguments matched
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-11-16-23-26-25.bpo-38821.-albNN.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix unhandled exceptions in :mod:`argparse` when internationalizing error messages for arguments with ``nargs`` set to special (non-integer) values. Patch by Federico Bond.