[typo] fix dupe in datetime.fromisoformat docs #17295
Conversation
Fixes a near word for word duplication of a sentence that appears earlier in the caution section for datetime.datetime.fromisoformat in Doc/Library/datetime.rst. No issue created as it's a trivial fix.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
@yawpitch Thanks for noticing and submitting the PR. Your contribution is appreciated! I can merge this once you have signed the CLA. 😄 |
|
@pganssle no problem; the CLA has been signed and submitted, just need to wait for the USA to catch up to the UK. 😉 |
|
Interestingly, this appears in the 3.8 version of the documentation but not the 3.7 version, even though the 3.7 documentation has the newer wording that mentions |
|
@yawpitch, thank you for the contribution. It appears that the bot isn't able to find the signed CLA yet. Can you check it again to make sure it matches to Github? Thanks! |
|
@csabella that's weird ... I've tried signing again using my more normal email address, but I've now got a signed CLA in my inbox for both the email address I use on the bugs.python.org site and the one that is my (private) email on Github. I'm wondering if the fact that I've got my email set to "private" on Github has anything to do with it? Does the automated check not just use my username? |
|
Thanks @yawpitch for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Fixes a nearly word for word duplication of a sentence that appears earlier in the caution section of datetime.datetime.fromisoformat in Doc/Library/datetime.rst. No issue created as it's a trivial change. Automerge-Triggered-By: @pganssle (cherry picked from commit e7b406f) Co-authored-by: Michael Morehouse <[email protected]>
|
GH-17686 is a backport of this pull request to the 3.8 branch. |
|
Thanks for your patience @yawpitch. I asked @ewdurbin about this and he said that when he checked the CLA status at the link from the bot, it triggered the bot to update the label (though I guess that's not a problem you will have again). Thanks again for your contribution! |
Fixes a nearly word for word duplication of a sentence that appears earlier in the caution section of datetime.datetime.fromisoformat in Doc/Library/datetime.rst. No issue created as it's a trivial change. Automerge-Triggered-By: @pganssle (cherry picked from commit e7b406f) Co-authored-by: Michael Morehouse <[email protected]>
|
@pganssle no problem at all, just a little docfix. Thanks for following up on it! M |
Fixes a nearly word for word duplication of a sentence that appears earlier in the caution section of datetime.datetime.fromisoformat in Doc/Library/datetime.rst. No issue created as it's a trivial change. Automerge-Triggered-By: @pganssle
Fixes a nearly word for word duplication of a sentence that appears
earlier in the caution section of datetime.datetime.fromisoformat in
Doc/Library/datetime.rst.
No issue created as it's a trivial change.
Automerge-Triggered-By: @pganssle