Skip to content

bpo-38878: Fix os.PathLike __subclasshook__ #17336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 22, 2019
Merged

bpo-38878: Fix os.PathLike __subclasshook__ #17336

merged 10 commits into from
Dec 22, 2019

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Nov 22, 2019 •
edited by bedevere-bot
Loading

Quick subclasshook fix. No need for tests, regression bugs cannot happen and the same method is being used in collections.abc (up to a certain degree).

https://bugs.python.org/issue38878

@brettcannon brettcannon self-requested a review November 22, 2019 17:53
brettcannon
brettcannon requested changes Nov 22, 2019
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide tests so that this functionality isn't accidentally removed in the future.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bharel
Copy link
Contributor Author

bharel commented Nov 22, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

ilevkivskyi
ilevkivskyi reviewed Nov 22, 2019
View reviewed changes
@bharel
Copy link
Contributor Author

bharel commented Nov 25, 2019

Alright, ready for merge.

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@bharel
Copy link
Contributor Author

bharel commented Dec 4, 2019

Ready for merge?

@ilevkivskyi
Copy link
Member

Ready for merge?

I will get back to this on the weekend.

@brettcannon brettcannon removed their request for review December 4, 2019 21:31
@bharel bharel requested a review from brettcannon December 21, 2019 12:44
ilevkivskyi
ilevkivskyi approved these changes Dec 22, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM now.

@ilevkivskyi
Copy link
Member

Also since this is technically a bug, I am going to backport this to 3.7 and 3.8.

@ilevkivskyi ilevkivskyi merged commit eae87e3 into python:master Dec 22, 2019
@miss-islington
Copy link
Contributor

Thanks @bharel for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @bharel and @ilevkivskyi, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eae87e3e4e0cb9a0ce10c2e101acb6995d79e09c 3.8

@miss-islington
Copy link
Contributor

Sorry @bharel and @ilevkivskyi, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker eae87e3e4e0cb9a0ce10c2e101acb6995d79e09c 3.7

@ilevkivskyi
Copy link
Member

@bharel Oops, there are conflicts, you can however do this manually.

@bharel bharel deleted the bpo-38878 branch December 23, 2019 12:36
bharel added a commit to bharel/cpython that referenced this pull request Dec 23, 2019
@bharel
[3.8] bpo-38878: Fix os.PathLike __subclasshook__ (pythonGH-17336)
7c28111 
Quick subclasshook fix using the same method is being used in collections.abc (up to a certain degree)..
(cherry picked from commit eae87e3)

Co-authored-by: Bar Harel <[email protected]>
@bedevere-bot
Copy link

GH-17684 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17685 is a backport of this pull request to the 3.7 branch.

ilevkivskyi pushed a commit that referenced this pull request Dec 23, 2019
@bharel @ilevkivskyi
[3.8] bpo-38878: Fix os.PathLike __subclasshook__ (GH-17336) (GH-17684)
0846e5d 
https://bugs.python.org/issue38878
ilevkivskyi pushed a commit that referenced this pull request Dec 23, 2019
@bharel @ilevkivskyi
[3.7] bpo-38878: Fix os.PathLike __subclasshook__ (GH-17336) (GH-17685)
59d06b9 
https://bugs.python.org/issue38878
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@bharel @shihai1991
bpo-38878: Fix os.PathLike __subclasshook__ (pythonGH-17336)
34af999 
Quick subclasshook fix using the same method is being used in collections.abc (up to a certain degree).
@bharel bharel mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

@ilevkivskyi ilevkivskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bharel @bedevere-bot @ilevkivskyi @miss-islington @brettcannon @the-knights-who-say-ni