Skip to content

bpo-39431: Mention nonlocal too in assignment quirk #17375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

shanavas786
Copy link
Contributor

@shanavas786 shanavas786 commented Nov 25, 2019

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 25, 2019
@shanavas786 shanavas786 changed the title Mention nonlocal too in assignment quirk bpo-39431: Mention nonlocal too in assignment quirk Jan 23, 2020
@python python deleted a comment from the-knights-who-say-ni Jan 23, 2020
@terryjreedy
Copy link
Member

PR with an issue should usually have a blurb, but adding two words is trivial enough to skip it.

@terryjreedy terryjreedy merged commit 7142df5 into python:master Jan 23, 2020
@miss-islington
Copy link
Contributor

Thanks @shanavas786 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

GH-18152 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington
Copy link
Contributor

Thanks @shanavas786 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@bedevere-bot
Copy link

GH-18153 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 23, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants