bpo-38914 Do not require email field in setup.py. #17388
Conversation
When checking `setup.py` and when the `author` field was provided, but the `author_email` field was missing, erroneously a warning message was displayed that the `author_email` field is required. The specs do not require the `author_email`field: https://packaging.python.org/specifications/core-metadata/#author The same is valid for `maintainer` and `maintainer_email`. The warning message has been adjusted. modified: Doc/distutils/examples.rst modified: Lib/distutils/command/check.py
jugmac00
changed the title
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I do not know whether this matters, but @pganssle proposed a change of wording over at
|
|
Well technically I did not |
|
Thanks for making the requested changes! @merwok: please review the changes made to this pull request. |
|
@jugmac00 I am fine with the wording changes, but I do think we should put in a news entry, since this is a user-facing behavior. Thank you for investigating this and making a PR! |
new file: Misc/NEWS.d/next/Library/2019-11-26-23-21-56.bpo-38914.8l-g-T.rst
modified: Lib/distutils/command/check.py
|
Thank you very much for your suggestions and for leading me through this pull request. As I do not know whether you squash pull requests anyway or you'd prefer me to do it locally and force push, I just did created some more commits for the requested changes. I will happily squash my commits locally and force push them - just leave me a note. |
|
Squashing does not play well with github reviews and links, so CPython uses messy branches + squash merge. All info in the devguide: https://devguide.python.org/gitbootcamp/#creating-a-pull-request |
|
I pushed a change to the wording of the news entry to clarify that this is just an adjustment to the wording of the warning and that otherwise the behavior has not changed. @jugmac00 If you agree with my new wording, I am happy to merge this. |
|
@pganssle Thanks for taking your time! lgtm :-) |
|
Small detail for future changes: there is no need to list modified files in the PR description, we can see that in github tabs and git metadata 🙂 |
Change project authorship to "python-restx Authors" and update LICENCE/setup.py accordingly to reflect ownership of the new fork. The author_email field has been removed from setup.py as it is no longer a required field python/cpython#17388 and setting up a python-restx team email is not a task we're looking to take on at the moment.
Change project authorship to "python-restx Authors" and update LICENCE/setup.py accordingly to reflect ownership of the new fork. The author_email field has been removed from setup.py as it is no longer a required field python/cpython#17388 and setting up a python-restx team email is not a task we're looking to take on at the moment.
Change project authorship to "python-restx Authors" and update LICENCE/setup.py accordingly to reflect ownership of the new fork. The author_email field has been removed from setup.py as it is no longer a required field python/cpython#17388 and setting up a python-restx team email is not a task we're looking to take on at the moment.
When checking `setup.py` and when the `author` field was provided, but the `author_email` field was missing, erroneously a warning message was displayed that the `author_email` field is required. The specs do not require the `author_email`field: https://packaging.python.org/specifications/core-metadata/#author The same is valid for `maintainer` and `maintainer_email`. The warning message has been adjusted. modified: Doc/distutils/examples.rst modified: Lib/distutils/command/check.py https://bugs.python.org/issue38914
When checking
setup.pyand when theauthorfield was provided, butthe
author_emailfield was missing, erroneously a warning message wasdisplayed that the
author_emailfield is required.The specs do not require the
author_emailfield:https://packaging.python.org/specifications/core-metadata/#author
The same is valid for
maintainerandmaintainer_email.The warning message has been adjusted.
modified: Doc/distutils/examples.rst
modified: Lib/distutils/command/check.py
https://bugs.python.org/issue38914
Automerge-Triggered-By: @pganssle