Skip to content

bpo-38927: Use python -m pip to upgrade venv deps #17403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

uranusjr
Copy link
Contributor

@uranusjr uranusjr commented Nov 27, 2019

vsajip
vsajip previously approved these changes Nov 27, 2019
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests also need updating

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uranusjr uranusjr force-pushed the venv-upgrade-use-dash-m branch from 5b1b5fb to 65e216e Compare November 27, 2019 17:04
@uranusjr uranusjr requested a review from vsajip November 27, 2019 17:51
@uranusjr
Copy link
Contributor Author

Test changed to match implementation.

@vsajip vsajip merged commit d9aa216 into python:master Nov 27, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
I suggest you add `bpo-NNNNN: ` as a prefix for the first commit for future PRs. Thanks!
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
I suggest you add `bpo-NNNNN: ` as a prefix for the first commit for future PRs. Thanks!
@uranusjr uranusjr deleted the venv-upgrade-use-dash-m branch October 5, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants