Skip to content

bpo-38524: clarify example a bit and improve formatting #17406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Nov 27, 2019

After merging PR GH-17364, I noticed that __set_name__ and type were not formatted as references, and that the code example could use a bit more context for clarity.

CC @DahlitzFlorian

https://bugs.python.org/issue38524

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Nov 27, 2019
@taleinat taleinat merged commit 02519f7 into python:master Nov 28, 2019
@taleinat taleinat deleted the bpo-38524/clarify-example-and-formatting branch November 28, 2019 05:22
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-17411 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2019
@bedevere-bot
Copy link

GH-17412 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2019
miss-islington added a commit that referenced this pull request Nov 28, 2019
miss-islington added a commit that referenced this pull request Nov 28, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants