Skip to content

[3.8] bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277) #17476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 5, 2019

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising UnboundLocalError on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa [email protected]

https://bugs.python.org/issue38698

…ythonGH-17277)

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising `UnboundLocalError` on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa <[email protected]>
Copy link
Contributor

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e21aa61 into python:3.8 Dec 5, 2019
@miss-islington miss-islington deleted the backport-bb81549-3.8 branch December 5, 2019 17:42
@miss-islington
Copy link
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants