Skip to content

bpo-39006: Fix asyncio when the ssl module is missing #17524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

bpo-39006: Fix asyncio when the ssl module is missing #17524

merged 1 commit into from
Dec 9, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 9, 2019 •
edited by bedevere-bot
Loading

Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.

https://bugs.python.org/issue39006

@vstinner
bpo-39006: Fix asyncio when the ssl module is missing
1f86a5a 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
@asvetlov
Copy link
Contributor

asvetlov commented Dec 9, 2019

Thanks, @vstinner
I've missed that we run tests without ssl module also.
I (wrongly) thought we dropped this configuration from the supported matrix at some time.

@vstinner
Copy link
Member Author

vstinner commented Dec 9, 2019

"I've missed that we run tests without ssl module also. I (wrongly) thought we dropped this configuration from the supported matrix at some time."

See https://bugs.python.org/issue39006 : it looks like a bug on the buildbot.

But I chose to write a fix since the code already handles ImportError on "import ssl".

If you consider that ssl is requires, test_asyncio must be skipped if ssl is missing and code handling ImportError should be removed.

IMHO supporting missing ssl doesn't require too much maintenance and so can be kept ;-)

@asvetlov
Copy link
Contributor

asvetlov commented Dec 9, 2019

@vstinner you are right.
The patch is correct, please merge it.

@asvetlov asvetlov mentioned this pull request Dec 9, 2019
Closed
@vstinner vstinner merged commit 82b4950 into python:master Dec 9, 2019
@vstinner vstinner deleted the asyncio_ssl branch December 9, 2019 14:02
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@vstinner @miss-islington
bpo-39006: Fix asyncio when the ssl module is missing (pythonGH-17524)
4692656 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
(cherry picked from commit 82b4950)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

GH-17527 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17528 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@vstinner @miss-islington
bpo-39006: Fix asyncio when the ssl module is missing (pythonGH-17524)
967727a 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
(cherry picked from commit 82b4950)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @vstinner
bpo-39006: Fix asyncio when the ssl module is missing (GH-17524)
b22183f 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
(cherry picked from commit 82b4950)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @vstinner
bpo-39006: Fix asyncio when the ssl module is missing (GH-17524)
a0078d9 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
(cherry picked from commit 82b4950)

Co-authored-by: Victor Stinner <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
bpo-39006: Fix asyncio when the ssl module is missing (pythonGH-17524)
66a50b2 
Fix asyncio when the ssl module is missing: only check for
ssl.SSLSocket instance if the ssl module is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni