Skip to content

Fixed a typo in the HTMLParser.feed docstrings #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dasdachs
Copy link
Contributor

The docstring started with an 'r', like a rawstring.

@mention-bot
Copy link

@dasdachs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezio-melotti, @freddrake and @bitdancer to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka merged commit 5ba1850 into python:master May 23, 2017
@serhiy-storchaka
Copy link
Member

Thank you for your patch @dasdachs. Do you mind to backport your change to other active branches (3.6, 3.5, and maybe 2.7)?

@dasdachs
Copy link
Contributor Author

Thank you @serhiy-storchaka! I'll backport the changes as soon as I can.

@vadmium
Copy link
Member

vadmium commented May 23, 2017

This looks wrong to me. It looks like it will have a real newline rather than the literal \n escape sequence. See commit 39f180b.

@serhiy-storchaka
Copy link
Member

Oh, my bad! I read the patch as adding the "r" prefix!

serhiy-storchaka added a commit that referenced this pull request May 23, 2017
… started with an 'r', like a rawstring. (#1759)"

This reverts commit 5ba1850.
@dasdachs
Copy link
Contributor Author

Of course it does. Sorry for the unnecesary work @serhiy-storchaka and thank you @vadmium!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants