Skip to content

gh-72587: prevent Py_DEBUG builds from trying to import limited ABI modules #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2018
Merged

gh-72587: prevent Py_DEBUG builds from trying to import limited ABI modules #1766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef0d5f
PyDEBUG builds don't support the limited ABI
stefanor May 22, 2017
15590e4
Tweak wording of news entry
brettcannon Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2018-11-03-10-37-29.bpo-28401.RprDIg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Debug builds will no longer to attempt to import extension modules built
for the ABI as they were never compatible to begin with.
Patch by Stefano Rivera.
2 changes: 2 additions & 0 deletions Python/dynload_shlib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ const char *_PyImport_DynLoadFiletab[] = {
".dll",
#else /* !__CYGWIN__ */
"." SOABI ".so",
#ifndef Py_DEBUG
".abi" PYTHON_ABI_STRING ".so",
#endif /* ! Py_DEBUG */
".so",
#endif /* __CYGWIN__ */
NULL,
Expand Down