Skip to content

gh-63283: IDNA prefix should be case insensitive #17726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2024
Merged

gh-63283: IDNA prefix should be case insensitive #17726

merged 5 commits into from
Mar 15, 2024

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Dec 28, 2019 •
edited by bedevere-app bot
Loading

Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-Authored-By: Pepijn de Vos [email protected]

https://bugs.python.org/issue19083

Automerge-Triggered-By: @asvetlov

@ZackerySpytz @pepijndevos
bpo-19083: IDNA prefix should be case insensitive
8ba3632 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-Authored-By: Pepijn de Vos <[email protected]>
@ZackerySpytz
Copy link
Contributor Author

I plan on adding a news entry.

corona10
corona10 approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

asvetlov
asvetlov reviewed Dec 29, 2019
View reviewed changes
asvetlov
asvetlov previously requested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good; please add NEWs entry.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pepijndevos
Copy link
Contributor

Original patch author chiming in. Happy to see some activity here after close to a decade. Don't think I have the necessary rights to do the NEWS entry though, so I'll just be patient.

@pepijndevos pepijndevos mannequin mentioned this pull request Jan 5, 2024
Closed
@erlend-aasland erlend-aasland changed the title bpo-19083: IDNA prefix should be case insensitive gh-63283: IDNA prefix should be case insensitive Jan 5, 2024
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 5, 2024
@encukou encukou dismissed asvetlov’s stale review March 13, 2024 16:25

I've added NEWS

@encukou encukou merged commit d180b50 into python:main Mar 15, 2024
@miss-islington-app
Copy link

Thanks @ZackerySpytz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2024
@ZackerySpytz @pepijndevos
@erlend-aasland @encukou @miss-islington
pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
7e992b1 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490GH-section-5).

(cherry picked from commit d180b50)

Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Pepijn de Vos <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2024

GH-116866 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 15, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2024
@ZackerySpytz @pepijndevos
@erlend-aasland @encukou @miss-islington
pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
14a63c5 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490GH-section-5).

(cherry picked from commit d180b50)

Co-authored-by: Zackery Spytz <[email protected]>
Co-authored-by: Pepijn de Vos <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 15, 2024

GH-116867 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 15, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@ZackerySpytz @pepijndevos
@erlend-aasland @encukou @vstinner
pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
a6dd4a5 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@ZackerySpytz @pepijndevos
@erlend-aasland @encukou @adorilson
pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
272eb90 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ZackerySpytz @pepijndevos
@erlend-aasland @encukou @diegorusso
pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
b5445be 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@asvetlov asvetlov asvetlov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ZackerySpytz @bedevere-bot @pepijndevos @asvetlov @corona10 @ambv @encukou @erlend-aasland @the-knights-who-say-ni @ezio-melotti