-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-66783: Automate update of Unicode data version in documentation #17748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nmassman and welcome!
I agree with the general idea behind the PR, it doesn't seem practical to maintain the latest Unicode version in 6 different locations, or for additional ones that are added in the future.
However, a few points (I might think of more later):
- You could store the version as a global constant in
conf.py
, I don't think we need a dedicated text file just to store the latest unicode version. UNICODE_VERSION
orUCS_VERSION
would be a far more explicit name for the constant. As far as I'm aware, "UCD" is not a commonly known acronym for Unicode.- IANAL, but I believe there are legal issues associated with copyrighting your own file additions. Our primary means of providing credit/acknowledgement to contributors these days is by adding a
Contributed by <name>.
sentence at the end of the news entry for the PR. You can add this in yourself.
/cc @merwok
Thanks for the feedback @aeros
I waffled on this a bit, but I went back and took another crack at it. Mostly I wanted to avoid having makeunicodedata.py accidentally mangle conf.py. I think I got it working reliably, though.
Kinda embarrassed that I didn't clean that up before submitting the PR. I should have slept first. :) I renamed everything to 'UNIDATA_VERSION' to match the original variable in makeunicodedata.py. This could just as easily be changed to 'UNICODE_VERSION', but I erred on the side of staying consistent to what was already in place.
I wasn't sure of the convention. I copied the heading format from what was in a few of the other sphinx extensions in the same directory. I inserted the bpo link instead (which was also in one of the other extensions), and updated the news entry. |
I think the comments in the file constitute a change log, not a copyright notice. The copyright situation is already handled by the CLA check, which ensures that the contribution has a suitable license. It seems OK to me to add a line there, even though there is external history in VCS metadata. |
I feel this would be easier by using rst_prolog like:
it would not need an extension. |
Closing per #66783 (comment) A |
Added a sphinx extension and modified makeunicodedata.py to automate updating documentation with the current Unicode version when it changes.
https://bugs.python.org/issue22593