bpo-29778: Fix incorrect NULL check #17818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit below introduced a NULL check which causes a call to _PyPathConfig_InitDLLPath() to be skipped if _Py_dll_path == NULL. python@c422167#diff-87aed37b4704d4e1513be6378c9c7fe6R169
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
corona10
reviewed
Jan 4, 2020
There was a problem hiding this comment.
@anthonywee Thanks for the contribution to CPython project.
Please sign up the CLA, please :)
zooba
added
needs backport to 3.8
OS-windows
type-bug
|
Thanks @anthonywee for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @anthonywee for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-17871 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 6, 2020
…H-17818) (cherry picked from commit 7b79dc9) Co-authored-by: Anthony Wee <[email protected]>
|
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
|
@anthonywee Hello, I just encountered this problem and entered this page according to the prompt, but I don't know how to operate below, Can the updated version be solved |
|
@zhangxueping-zxp the python bug https://bugs.python.org/issue29778 should have the information about which versions were fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit below introduced a NULL check which causes a call to _PyPathConfig_InitDLLPath()
to be skipped if _Py_dll_path == NULL.
c422167#diff-87aed37b4704d4e1513be6378c9c7fe6R169
https://bugs.python.org/issue29778