clinic: Fix clinic anti-pattern #17852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
approved these changes
Jan 6, 2020
|
Thanks @corona10 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2020
(cherry picked from commit 5136e72) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2020
(cherry picked from commit 5136e72) Co-authored-by: Dong-hee Na <[email protected]>
|
Normally, we don't accept this kind of refactorings to not mess too much with the blame, but the fix is simple enough so I will merge. Note: we cannot risk backports to 3.8 and 3.7 branches as this is not a bugfix. Please, take into account in the future when adding the 'needs backport' labels. |
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jan 6, 2020
argument-clinic: Simplify multi-line string handling (pythonGH-17852)
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/msg359368