Skip to content

bpo-39234: Doc: enum.auto() incrementation value not specified. #17872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2020
Merged

bpo-39234: Doc: enum.auto() incrementation value not specified. #17872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ed9d3
`enum.auto()` incrementation value not specified.
YoSTEALTH Jan 6, 2020
3f10a68
updated content as per Eric comment.
YoSTEALTH Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/library/enum.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ helper, :class:`auto`.

.. class:: auto

Instances are replaced with an appropriate value for Enum members.
Instances are replaced with an appropriate value for Enum members. Initial value starts at 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need two spaces after the period. I'm now thinking that this should say "By default, the initial value starts at 1", since it's possible to override it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvsmith Someone needs to go through the Enum docs and rewrite them. If no one else does I will later this year. For inspiration:

https://www.divio.com/blog/documentation/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvsmith: Sorry I jumped the gun on that one. If @YoSTEALTH make that last change feel free to commit it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to edit this file, its already merged? do i have to recreate the pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoSTEALTH : It's been merged. I don't think it's super-important to fix, but if you want to create a new PR I'll merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvsmith i recreated it #17878


.. versionadded:: 3.6 ``Flag``, ``IntFlag``, ``auto``

Expand Down