-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-39259: smtp.SMTP/SMTP_SSL now reject timeout = 0 #17958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vstinner During I work on this PR, I've noticed that LMTP does not support the timeout parameter. However, LMTP also able to use the socket which is created from SMTP. Line 1076 in 100fafc
IMHO LMTP needs to support the timeout parameter.
Also AFAIK, Unix Socket also able to set a timeout which is used for LMTP protocol |
e1d29a6
to
29cd207
Compare
If you think so, please open a separated issue. It's not directly related to https://bugs.python.org/issue39259 |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the requested changes; please review again
https://bugs.python.org/issue39259