bpo-39259: ftplib.FTP/FTP_TLS now reject timeout = 0 #17959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
force-pushed
the
bpo-39259-ftplib
branch
from
0e9e0ae to
7fa1935
Compare
corona10
force-pushed
the
bpo-39259-ftplib
branch
from
7fa1935 to
abda7c4
Compare
vstinner
approved these changes
Jan 13, 2020
| @@ -1045,6 +1045,10 @@ def testTimeoutValue(self): | |||
| self.evt.wait() | |||
| ftp.close() | |||
|
|
|||
| # bpo-39259 | |||
| with self.assertRaises(ValueError): | |||
| ftplib.FTP(HOST, timeout=0) | |||
There was a problem hiding this comment.
FTP_TLS is not tested, but I don't think that its a big deal. FTP_TLS requires to check if ssl is available, and the current test suite isn't properly designed to test FTP and FTP_TLS at the same time.
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jan 13, 2020
bpo-39259: ftplib.FTP/FTP_TLS now reject timeout = 0 (pythonGH-17959)
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39259