Skip to content

bpo-39329: Add timeout parameter for LMTP #17998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 14, 2020

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should document the new parameter at https://docs.python.org/dev/library/smtplib.html#smtplib.LMTP : update the function and add a "versionchanged 3.9" markup (see other files for the exact syntax, look at os.rst maybe). You can also document the new feature in Doc/whatsnew/3.9.rst

@corona10 corona10 changed the title [WIP] bpo-39329: Add timeout parameter for LMTP bpo-39329: Add timeout parameter for LMTP Jan 14, 2020
@corona10 corona10 force-pushed the bpo-39329 branch 2 times, most recently from b19af6f to a54467e Compare January 14, 2020 13:37
Copy link
Member Author

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner
Please take a look.
Question:
For this PR, some tests codes are updated for these, is it okay to apply PEP8?
e.g: testBasic1 -> test_basic1

@corona10 corona10 requested a review from vstinner January 14, 2020 14:05
@corona10 corona10 requested a review from vstinner January 14, 2020 15:10
@corona10
Copy link
Member Author

@vstinner Updated!

@vstinner vstinner merged commit 65a5ce2 into python:master Jan 14, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants