-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-39329: Add timeout parameter for LMTP #17998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should document the new parameter at https://docs.python.org/dev/library/smtplib.html#smtplib.LMTP : update the function and add a "versionchanged 3.9" markup (see other files for the exact syntax, look at os.rst maybe). You can also document the new feature in Doc/whatsnew/3.9.rst
b19af6f
to
a54467e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner
Please take a look.
Question:
For this PR, some tests codes are updated for these, is it okay to apply PEP8?
e.g: testBasic1 -> test_basic1
Misc/NEWS.d/next/Library/2020-01-14-22-16-07.bpo-39329.6OKGBn.rst
Outdated
Show resolved
Hide resolved
@vstinner Updated! |
https://bugs.python.org/issue39329