Skip to content

bpo-39366: Remove xpath() and xgtitle() methods of NNTP. #18035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 22, 2020
Merged

bpo-39366: Remove xpath() and xgtitle() methods of NNTP. #18035

merged 4 commits into from
Jan 22, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 17, 2020 •
edited
Loading

@corona10 corona10 requested a review from vstinner January 17, 2020 09:16
@corona10 corona10 changed the title bpo-39336: Remove xpath() and xgtitle() methods of NNTP. bpo-39366: Remove xpath() and xgtitle() methods of NNTP. Jan 17, 2020
vstinner
vstinner reviewed Jan 17, 2020
View reviewed changes
vstinner
vstinner approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would prefer to have a second review, since I'm not used to nntplib.

@serhiy-storchaka @vadmium @berkerpeksag @pitrou: Can one of you please review this PR as well? Well, IMO the PR itself is fine, the question is more if you are ok to drop these two deprecated methods.

berkerpeksag
berkerpeksag requested changes Jan 19, 2020
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10
corona10 commented Jan 20, 2020
View reviewed changes
Copy link
Member Author

@corona10 corona10 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@berkerpeksag

Thanks for the review!
I have made the requested changes; please review again

@corona10 corona10 requested a review from berkerpeksag January 20, 2020 03:53
vstinner
vstinner approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @berkerpeksag: @corona10 addressed your remarks, would you mind to review it again?

berkerpeksag
berkerpeksag approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@berkerpeksag berkerpeksag merged commit 1f0f102 into python:master Jan 22, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
bpo-39366: Remove xpath() and xgtitle() methods of NNTP (pythonGH-18035)
e97ebb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @bedevere-bot @berkerpeksag @vstinner @the-knights-who-say-ni