bpo-39378: partial of PickleState struct should be traversed. #18046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihai1991
requested review from
ncoghlan and
serhiy-storchaka
and removed request for
ncoghlan
|
@serhiy-storchaka Hi, serhiy. Do you have free time to review this small PR? |
zhangyangyu
approved these changes
Mar 2, 2020
serhiy-storchaka
approved these changes
Mar 2, 2020
|
Thanks @shihai1991 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2020
…GH-18046) (cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>
|
GH-18730 is a backport of this pull request to the 3.8 branch. |
|
Good catch! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 2, 2020
…GH-18046) (cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>
|
GH-18731 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 2, 2020
(cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 2, 2020
(cherry picked from commit 1f577ce) Co-authored-by: Hai Shi <[email protected]>
|
Thanks, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39378