Skip to content

bpo-39383: Mention Darwin as a potential value for platform.system() #18054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2020
Merged

bpo-39383: Mention Darwin as a potential value for platform.system() #18054

merged 1 commit into from
Jan 20, 2020

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Jan 18, 2020 •
edited by bedevere-bot
Loading

This change mentions 'Darwin' as a possible value for

platform.system()

in the documentation of the platform module.

https://bugs.python.org/issue39383

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 18, 2020
@bittner bittner changed the title Mention Darwin as a potential value for platform.system() bpo-39383: Mention Darwin as a potential value for platform.system() Jan 18, 2020
@csabella
Copy link
Contributor

I think this is a great suggestion, but I don't think you need the parenthetical for macOS.

ned-deily
ned-deily requested changes Jan 18, 2020
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bittner
Copy link
Contributor Author

bittner commented Jan 19, 2020

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily
ned-deily approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ned-deily ned-deily merged commit 8d57a41 into python:master Jan 20, 2020
@miss-islington
Copy link
Contributor

Thanks @bittner for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2020
@bittner @miss-islington
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
d86bb80 
…ythonGH-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <[email protected]>
@bedevere-bot
Copy link

GH-18088 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2020
@bittner @miss-islington
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
4fc53b9 
…ythonGH-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <[email protected]>
@bedevere-bot
Copy link

GH-18089 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 20, 2020
@miss-islington @bittner
bpo-39383: Mention Darwin as a potential value for platform.system() (G…
3da8390 
…H-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <[email protected]>
miss-islington added a commit that referenced this pull request Jan 20, 2020
@miss-islington @bittner
bpo-39383: Mention Darwin as a potential value for platform.system() (G…
c1964e0 
…H-18054)

(cherry picked from commit 8d57a41)

Co-authored-by: Peter Bittner <[email protected]>
@bittner bittner deleted the docs/mention-macos-platform-system branch January 21, 2020 07:39
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@bittner @shihai1991
bpo-39383: Mention Darwin as a potential value for platform.system() (p…
2caad14 
…ythonGH-18054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bittner @csabella @bedevere-bot @miss-islington @ned-deily @the-knights-who-say-ni