bpo-39416: Document some restrictions on the default string representations of numeric classes #18111
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
kpinc
changed the title
|
Note that the "when possible" in "The representation is in base 10, when possible." |
|
You can use this web app to add a NEWS entry: https://blurb-it.herokuapp.com/ |
Thanks. Done. |
Misc/NEWS.d/next/Documentation/2020-01-22-05-14-53.bpo-39416.uYjhEm.rst
Outdated
Show resolved
Hide resolved
merwok
changed the title
|
Sorry, clicked on the close button by mistake! I edited the title to remove redundant |
kpinc
changed the title
And here I thought you were making my life simpler. ;-)
Done. |
|
On Tue, 20 Oct 2020 08:45:32 -0700 Éric Araujo ***@***.***> wrote:
@merwok commented on this pull request.
I think the extra indenting here creates a block quote, can you fix
it?
Done. Sorry about that.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
|
|
Change looks good to me. @ericvsmith would you mind giving a +1? You were on the mailing-list thread where some people expressed concern about not guaranteeing too much here. |
|
Thanks @kpinc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…ations of numeric classes (pythonGH-18111) [bpo-39416](): Document string representations of the Numeric classes This is a change to the specification of the Python language. The idea here is to put sane minimal limits on the Python language's default representations of its Numeric classes. That way "Marty's Robotic Massage Parlor and Python Interpreter" implementation of Python won't do anything too crazy. Some discussion in the email thread: Subject: Documenting Python's float.__str__() https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/ (cherry picked from commit c60394c) Co-authored-by: kpinc <[email protected]>
|
GH-22860 is a backport of this pull request to the 3.9 branch. |
…ations of numeric classes (pythonGH-18111) [bpo-39416](): Document string representations of the Numeric classes This is a change to the specification of the Python language. The idea here is to put sane minimal limits on the Python language's default representations of its Numeric classes. That way "Marty's Robotic Massage Parlor and Python Interpreter" implementation of Python won't do anything too crazy. Some discussion in the email thread: Subject: Documenting Python's float.__str__() https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/ (cherry picked from commit c60394c) Co-authored-by: kpinc <[email protected]>
|
GH-22861 is a backport of this pull request to the 3.8 branch. |
| @@ -182,6 +182,24 @@ Ellipsis | |||
| related to mathematical numbers, but subject to the limitations of numerical | |||
| representation in computers. | |||
|
|
|||
| The string representations of the Numeric classes, computed by | |||
There was a problem hiding this comment.
Ah, this should have been changed to numeric too, but that’s very minor so I will leave it and merge the backport PRs as is.
…resentations of numeric classes (GH-18111) (GH-22860) [[bpo-39416]()](): Document string representations of the Numeric classes This is a change to the specification of the Python language. The idea here is to put sane minimal limits on the Python language's default representations of its Numeric classes. That way "Marty's Robotic Massage Parlor and Python Interpreter" implementation of Python won't do anything too crazy. Some discussion in the email thread: Subject: Documenting Python's float.__str__() https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/ (cherry picked from commit c60394c) Co-authored-by: kpinc <[email protected]> Automerge-Triggered-By: GH:merwok
…resentations of numeric classes (GH-18111) (GH-22861) [[bpo-39416]()](): Document string representations of the Numeric classes This is a change to the specification of the Python language. The idea here is to put sane minimal limits on the Python language's default representations of its Numeric classes. That way "Marty's Robotic Massage Parlor and Python Interpreter" implementation of Python won't do anything too crazy. Some discussion in the email thread: Subject: Documenting Python's float.__str__() https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/ (cherry picked from commit c60394c) Co-authored-by: kpinc <[email protected]> Automerge-Triggered-By: GH:merwok
|
On Wed, 21 Oct 2020 10:16:55 -0700 Éric Araujo ***@***.***> wrote:
@merwok commented on this pull request.
> @@ -182,6 +182,24 @@ Ellipsis
related to mathematical numbers, but subject to the limitations
of numerical representation in computers.
+ The string representations of the Numeric classes, computed by
Ah, this should have been changed to `numeric` too, but that’s very
minor so I will leave it and merge the backport PRs as is.
How do you want me to approach fixing this? Should I submit a
new PR? Is it not worth the time to fix??
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
|
I think a new PR. You don't need an issue. Mention it here and someone will approve it. |
|
On Wed, 21 Oct 2020 12:43:45 -0700 "Eric V. Smith" ***@***.***> wrote:
> How do you want me to approach fixing this? Should I submit a new
> PR? Is it not worth the time to fix??
I think a new PR. You don't need an issue. Mention it here and
someone will approve it.
I have a new PR. #22867
Fix [bpo-39416](https://bugs.python.org/issue39416): Change "Numeric" to lower case; an english word, not a class name #22867
It is running the CI tests now. (But has already failed the lack
of NEWS entry.)
I did not make a NEWS entry. It seemed too trivial and, I hope,
conforms with policy that a news entry is not needed. (Although
I don't know exactly what branches the patch got backported to.)
Please let me know if you want a NEWS entry or if anything
else needs fixing. Thanks.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
|
…ations of numeric classes (pythonGH-18111) [bpo-39416](): Document string representations of the Numeric classes This is a change to the specification of the Python language. The idea here is to put sane minimal limits on the Python language's default representations of its Numeric classes. That way "Marty's Robotic Massage Parlor and Python Interpreter" implementation of Python won't do anything too crazy. Some discussion in the email thread: Subject: Documenting Python's float.__str__() https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/
bpo-39416: Document string representations of the Numeric classes
This is a change to the specification of the Python language.
The idea here is to put sane minimal limits on the Python language's default
representations of its Numeric classes. That way "Marty's Robotic Massage Parlor
and Python Interpreter" implementation of Python won't do anything too
crazy.
Some discussion in the email thread:
Subject: Documenting Python's float.str()
https://mail.python.org/archives/list/[email protected]/thread/FV22TKT3S2Q3P7PNN6MCXI6IX3HRRNAL/
https://bugs.python.org/issue39416
Automerge-Triggered-By: GH:merwok