Skip to content

bpo-39406: Implement os.putenv() with setenv() if available #18128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2020
Merged

bpo-39406: Implement os.putenv() with setenv() if available #18128

merged 2 commits into from
Jan 22, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 22, 2020

If setenv() C function is available, os.putenv() is now implemented
with setenv() instead of putenv(), so Python doesn't have to handle
the environment variable memory.

https://bugs.python.org/issue39406

If setenv() C function is available, os.putenv() is now implemented
with setenv() instead of putenv(), so Python doesn't have to handle
the environment variable memory.
@vstinner
Copy link
Member Author

Previous version of the PR, approved by @serhiy-storchaka: PR #18095

This PR no longer uses SetEnvironmentVariableW() on Windows.

@vstinner vstinner merged commit b477d19 into python:master Jan 22, 2020
@vstinner vstinner deleted the setenv2 branch January 22, 2020 21:48
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…-18128)

If setenv() C function is available, os.putenv() is now implemented
with setenv() instead of putenv(), so Python doesn't have to handle
the environment variable memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants