Skip to content

Update 3.8.rst #18173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2020
Merged

Update 3.8.rst #18173

merged 1 commit into from
Jan 25, 2020

Conversation

fireattack
Copy link
Contributor

Fixed the name of the contributor (@selik).

@fireattack
Update 3.8.rst
afec522 
Fixed the name of the contributor (@selik).
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@fireattack

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 24, 2020
selik
selik approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@selik selik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, didn't realize my name had been misspelled.

@csabella csabella merged commit 9bfb4a7 into python:master Jan 25, 2020
@miss-islington
Copy link
Contributor

Thanks @fireattack for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @fireattack for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
@fireattack @miss-islington
Update 3.8.rst (pythonGH-18173)
7a95960 
Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack <[email protected]>
@bedevere-bot
Copy link

GH-18182 is a backport of this pull request to the 3.8 branch.

@csabella
Copy link
Contributor

@fireattack, thanks for catching that and for making the PR!

csabella pushed a commit that referenced this pull request Jan 25, 2020
@miss-islington @fireattack @csabella
Update 3.8.rst (GH-18173) (#18182)
079dfe0 
Fixed the name of the contributor (@selik).
(cherry picked from commit 9bfb4a7)

Co-authored-by: fireattack <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@fireattack @shihai1991
Update 3.8.rst (pythonGH-18173)
04071d1 
Fixed the name of the contributor (@selik).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selik selik selik approved these changes

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fireattack @the-knights-who-say-ni @miss-islington @bedevere-bot @csabella @selik