bpo-39460: Disable test_zipfile.test_add_file_after_2107() #18247
Conversation
Disable the test because it fails on Fedora Rawhide with XFS filesystem.
|
Can we do a detection on only skip if the timestamp is weird? |
Maybe. But it seems simpler to me to skip the test until the kernel bug is fixed. |
Codecov Report
@@ Coverage Diff @@
## master #18247 +/- ##
=========================================
Coverage 82.12% 82.12%
=========================================
Files 1955 1954 -1
Lines 588721 583389 -5332
Branches 44382 44382
=========================================
- Hits 483463 479090 -4373
+ Misses 95628 94673 -955
+ Partials 9630 9626 -4
Continue to review full report at Codecov.
|
| @@ -616,6 +616,18 @@ def test_add_file_after_2107(self): | |||
| except OverflowError: | |||
| self.skipTest('Host fs cannot set timestamp to required value.') | |||
|
|
|||
| mtime_ns = os.stat(TESTFN).st_mtime_ns | |||
| if mtime_ns != (4386268800 * 10**9): | |||
There was a problem hiding this comment.
Just curious. Would you consider this better or worse than the 2 lines one?
| if mtime_ns != (4386268800 * 10**9): | |
| if (mtime_ns := os.stat(TESTFN).st_mtime_ns) != (4386268800 * 10**9): |
There was a problem hiding this comment.
My opinion: I prefer to not use "mtime := ..." here. I like to have an explicitement assignement statement on a separated line ;-)
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
I'm having trouble backporting to |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-18253 is a backport of this pull request to the 3.8 branch. |
XFS filesystem is limited to 32-bit timestamp, but the utimensat() syscall doesn't fail. Moreover, there is a VFS bug which returns a cached timestamp which is different than the value on disk. https://bugzilla.redhat.com/show_bug.cgi?id=1795576 https://bugs.python.org/issue39460GH-msg360952 (cherry picked from commit 3cb49b6) Co-authored-by: Victor Stinner <[email protected]>
XFS filesystem is limited to 32-bit timestamp, but the utimensat() syscall doesn't fail. Moreover, there is a VFS bug which returns a cached timestamp which is different than the value on disk. https://bugzilla.redhat.com/show_bug.cgi?id=1795576 https://bugs.python.org/issue39460GH-msg360952 (cherry picked from commit 3cb49b6) Co-authored-by: Victor Stinner <[email protected]>
XFS filesystem is limited to 32-bit timestamp, but the utimensat() syscall doesn't fail. Moreover, there is a VFS bug which returns a cached timestamp which is different than the value on disk. https://bugzilla.redhat.com/show_bug.cgi?id=1795576 https://bugs.python.org/issue39460#msg360952
Disable the test because it fails on Fedora Rawhide with XFS
filesystem.
https://bugs.python.org/issue39460