Skip to content

bpo-38631: Replace Py_FatalError() with assert() in ceval.c #18279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2020
Merged

bpo-38631: Replace Py_FatalError() with assert() in ceval.c #18279

merged 2 commits into from
Jan 30, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 30, 2020

Replace a few Py_FatalError() calls if tstate is NULL with
assert(tstate != NULL) in ceval.c.

PyEval_AcquireThread(), PyEval_ReleaseThread() and
PyEval_RestoreThread() must never be called with a NULL tstate.

https://bugs.python.org/issue38631

Replace a few Py_FatalError() calls if tstate is NULL with
assert(tstate != NULL) in ceval.c.

PyEval_AcquireThread(), PyEval_ReleaseThread() and
PyEval_RestoreThread() must never be called with a NULL tstate.
@vstinner vstinner merged commit 17c68b8 into python:master Jan 30, 2020
@vstinner vstinner deleted the ceval_fatal_error branch January 30, 2020 11:20
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
…-18279)

Replace a few Py_FatalError() calls if tstate is NULL with
assert(tstate != NULL) in ceval.c.

PyEval_AcquireThread(), PyEval_ReleaseThread() and
PyEval_RestoreThread() must never be called with a NULL tstate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants