Skip to content

bpo-39579: Change Attribute end_col_offset to point at the current node #18405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2020
Merged

bpo-39579: Change Attribute end_col_offset to point at the current node #18405

merged 4 commits into from
Feb 7, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Feb 7, 2020 •
edited by bedevere-bot
Loading

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #18405 into master will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18405       +/-   ##
===========================================
+ Coverage   82.11%   83.19%    +1.07%     
===========================================
  Files        1955     1570      -385     
  Lines      588908   414401   -174507     
  Branches    44429    44429               
===========================================
- Hits       483597   344762   -138835     
+ Misses      95665    59993    -35672     
  Partials     9646     9646
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 437 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10dc3e...f1456d9. Read the comment docs.

@lysnikolaou lysnikolaou mentioned this pull request Feb 7, 2020
Merged
@gvanrossum
Copy link
Member

This looks straightforward -- I'll merge it now.

@gvanrossum gvanrossum merged commit d2e1098 into python:master Feb 7, 2020
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @lysnikolaou and @gvanrossum, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d2e1098641f98594702ef29049c3c4a3f394786f 3.8

@gvanrossum
Copy link
Member

@lysnikolaou Can you look into the backport?

@lysnikolaou
Copy link
Member Author

@lysnikolaou Can you look into the backport?

On it.

lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Feb 8, 2020
@lysnikolaou
bpo-39579: Fix Attribute end_col_offset to point at the current node (p…
f2e769d 
…ythonGH-18405)

(cherry picked from commit d2e1098)
@bedevere-bot
Copy link

GH-18408 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit that referenced this pull request Feb 8, 2020
@lysnikolaou
[3.8] bpo-39579: Fix Attribute end_col_offset to point at the current…
8b9cebc 
… node (GH-18405) (GH-18408)

(cherry picked from commit d2e1098)





https://bugs.python.org/issue39579



Automerge-Triggered-By: @gvanrossum
@lysnikolaou lysnikolaou deleted the decorators-col branch February 8, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@gvanrossum gvanrossum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysnikolaou @gvanrossum @miss-islington @bedevere-bot @the-knights-who-say-ni