bpo-39609: set the thread_name_prefix for the default asyncio executor #18458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmohrhard
force-pushed
the
bpo39609-add_thread_name_prefix_to_asyncio_executor
branch
from
7ca1ec6 to
b9078e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #18458 +/- ##
==========================================
- Coverage 82.20% 82.12% -0.09%
==========================================
Files 1957 1954 -3
Lines 589324 583606 -5718
Branches 44428 44428
==========================================
- Hits 484430 479259 -5171
+ Misses 95233 94702 -531
+ Partials 9661 9645 -16
Continue to review full report at Codecov.
|
asvetlov
reviewed
Feb 24, 2020
Lib/asyncio/base_events.py
Outdated
| @@ -806,7 +806,9 @@ def run_in_executor(self, executor, func, *args): | |||
| # Only check when the default executor is being used | |||
| self._check_default_executor() | |||
| if executor is None: | |||
| executor = concurrent.futures.ThreadPoolExecutor() | |||
| executor = concurrent.futures.ThreadPoolExecutor( | |||
| thread_name_prefix='asyncio_default_executor' | |||
There was a problem hiding this comment.
A shorter name is better, please apply it.
Suggested change
| thread_name_prefix='asyncio_default_executor' | |
| thread_name_prefix='asyncio' |
mmohrhard
force-pushed
the
bpo39609-add_thread_name_prefix_to_asyncio_executor
branch
from
b9078e6 to
d9d31c9
Compare
asvetlov
approved these changes
Feb 27, 2020
|
Sorry, I can't merge this PR. Reason: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small debugging improvement to identify the asyncio executor threads.
https://bugs.python.org/issue39609
Automerge-Triggered-By: @asvetlov